Convert ecr values to rounds

src/pages/1_Keepers.py

@@ -21,9 +21,16 @@ def load_adp() -> pd.DataFrame:
     return df
 
 
+def convert_ecr_to_round_val(ecr_float: float) -> float:
+    # As a float, store pick 1 of round 1 as 1.0
+    return 1.0 + (ecr_float - 1.0) / LEAGUE_NUMBER_TEAMS
+
+
 def add_opinionated_keeper_value(df: pd.DataFrame):
     for score_fmt in ["1qb", "2qb"]:
-        df[f"value_{score_fmt}"] = (df["keeper_cost"] - 0.5) * LEAGUE_NUMBER_TEAMS - df[f"ecr_{score_fmt}"]
+        df[f"ecr_{score_fmt}"] = df[f"ecr_{score_fmt}"].apply(convert_ecr_to_round_val)
+        # assumes midround keeper
+        df[f"value_{score_fmt}"] = df["keeper_cost"] + 0.5 - df[f"ecr_{score_fmt}"]
 
 
 @st.cache_data(ttl=60 * 60 * 24)
@@ -107,16 +114,16 @@ def filtered_keeper_dataframe(data: pd.DataFrame, teams_list: list[str]):
                 help="Number of further consecutive seasons player can be kept (subject to maximum of 2)",
             ),
             "ecr_1qb": st.column_config.NumberColumn(
-                label="ECR 1QB", help="Player's average Expert Consensus Rank (ECR) for 1 QB League"
+                label="ECR 1QB", help="Player's average draft round.pick Expert Consensus Rank (ECR) for 1 QB League"
             ),
             "value_1qb": st.column_config.NumberColumn(
-                label="Value 1QB", help="Approx. number of draft picks of keeper value vs ECR 1QB"
+                label="Value 1QB", help="Approx. number of draft rounds of keeper value vs ECR 1QB"
             ),
             "ecr_2qb": st.column_config.NumberColumn(
-                label="ECR 2QB", help="Player's average Expert Consensus Rank (ECR) for 2 QB League"
+                label="ECR 2QB", help="Player's average draft round.pick Expert Consensus Rank (ECR) for 2 QB League"
             ),
             "value_2qb": st.column_config.NumberColumn(
-                label="Value 2QB", help="Approx. number of draft picks of keeper value vs ECR 2QB"
+                label="Value 2QB", help="Approx. number of draft rounds of keeper value vs ECR 2QB"
             ),
             "ecr_pos": st.column_config.NumberColumn(
                 label="ECR Position", help="Player's average Expert Consensus Rank (ECR) at the player's position"